added tdid and ad-unit-code #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswhitney
approved these changes
Jun 16, 2020
* added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * added support for floors module * using floorModule to set floor * removed commented console.log statements
* access floor from floors module * int -> float and null check * let -> const
* appnexusBidAdapter - fix video params * remove mimes field
* added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * id value should be string only * id value should be string; changed test data * pubmatic using userIdAsEids commented unnecessary code PubMatic will no longer read Digitrust from config or independent library setup PubMatic will no loner read TTDID from config or independent library setup * chnages in test cases for userIdAsEids commented unnecessary test cases PubMatic will no longer read Digitrust from config or independent library setup PubMatic will no loner read TTDID from config or independent library setup * deleted commented code and test cases * deleted a commented line * lint effect
weswhitney
reviewed
Jun 19, 2020
| expect(payload.imp[0].banner.format).to.deep.equal([{w: 300, h: 250}, {w: 300, h: 600}]) | ||
| expect(payload.imp[0].banner.w).to.equal(1) | ||
| expect(payload.imp[0].banner.h).to.equal(1) | ||
| }) | ||
|
|
||
| it('includes the ad unit code int the request', function() { |
weswhitney
approved these changes
Jun 19, 2020
* externalIds (SIM-657) Added external ids and associated unit test. * externalIds - Added DEFAULT_PARAMS_WITH_EIDS that contains the external id information for the unit test * externalIds (SIM-657) uses createEidsArray found in the eid.js * externalIds cleanup spaces and tabs, adding a missing import for createEids in eids.js * externalIds adding a space where it is needed to fix a wonderful test.
* check gdpr in buildRequest * User sync based on whether gdpr applies or not * check if consent data exists during user sync * split user sync into further branches: 1) when gdpr does not apply 2) when consent data is unavailable * contribute viewability to ttxRequest * update tests * remove window mock from tests * use local variables * introduce ServerRequestBuilder * add withOptions() method to ServerRequestBuilder * add semicolons * sync up package-lock.json with upstream/master * stub window.top in tests * introduce getTopWindowSize() for test purpose * reformat code * add withSite() method to TtxRequestBuilder add withSite() method to TtxRequestBuilder * add isIframe() and _isViewabilityMeasurable() * handle NON_MEASURABLE viewability in nested iframes * consider page visibility, stub utils functions getWindowTop() and getWindowSelf() * contribute viewability as 0 for inactive tab * add prebidjs version to ttx request * send caller as an array * fix JSDoc in utils.js * send viewability as non measurable when unable to locate target HTMLElement, add warning message * introduce mapAdSlotPathToElementId() * introduce getAdSlotHTMLElement(), add logging * introduce mapAdSlotPathToElementId() * update logging in ad unit path to element id mapping * rephrase logging, fix tests * update adapter documentation * remove excessive logging * improve logging * revert change * fix return of _mapAdUnitPathToElementId() * improve logging of _mapAdUnitPathToElementId() * do not use Array.find() * return id once element is found * return id once element is found * let -> const * Removing killswitch behavior for GDPR * Updated comments to reflect current gdpr logic * URI encode consent string * Updated example site ID to help Prebid team e2e test our adapter * send page url in ortb * Removed redundant pageUrl default * Restored package-log.json that mirrors prebid's repo * Sending USP string during buildRequest * Adding USP consent data to user sync * add unit test for syncing without bidrequest * Changed to uspConsent to make the connatation consistent * Resetting adapter state in adapter after user sync rather than exposing it. * removed console log * Adding schain info * remove setting empty format ext * better tests invalid values * removing validation of schain * Fixed lint errors Co-authored-by: Gleb Glushtsov <gleb.glushtsov@33across.com> Co-authored-by: Gleb Glushtsov <glebglushtsov@users.noreply.github.com> Co-authored-by: Gleb Glushtsov <gleb.glushtsov@gmail.com> Co-authored-by: Aparna Hegde <ahegde@pool-10-1-150-29-nyc.internal.33across.com> Co-authored-by: Aparna Hegde <ahegde@admins-MacBook-Pro.local> Co-authored-by: Aparna Hegde <ahegde@pool-10-1-150-137-nyc.internal.33across.com> Co-authored-by: Aparna Hegde <ahegde@pool-10-1-150-96-nyc.internal.33across.com> Co-authored-by: Aparna Hegde <ahegde@AHEGDE-MAC.local> Co-authored-by: Aparna Hegde <ahegde@AHEGDE-MAC.fios-router.home>
* added waardex adapter * removed support http from adapter Co-authored-by: Max Shuhaliia <mshuhaliia@Maxs-MacBook-Pro-2.local>
Customers are using custom parameters to our endpoint to use them downstream. We need a way of supporting this in prebid.
* feat(module): multi size request * fix getUserSyncs added tests * update(module): package-lock.json from master * feat(client): add user id request support * fix(client): lint errors Co-authored-by: roman <shmoop207@gmail.com>
* LiveIntentId submodule. Bumped the live-connect-js version with changes: - fixed the problem where userId/index.js was sending the full config on `decode`, while the docs claim it should only send `.params` - removed the uuid lib - removed the support for legacy LI first party cookies - removed the redundant config parameter `providedIdentifierName` - support for running live-connect inside of multiple wrappers * LiveIntentId submodule. Removed reading of non-accessible and therefore redundant code snippets * Removed excessive config logging. * Making the publisher id parameter optional. * Removed unneeded check.
* check gdpr in buildRequest * User sync based on whether gdpr applies or not * check if consent data exists during user sync * split user sync into further branches: 1) when gdpr does not apply 2) when consent data is unavailable * contribute viewability to ttxRequest * update tests * remove window mock from tests * use local variables * introduce ServerRequestBuilder * add withOptions() method to ServerRequestBuilder * add semicolons * sync up package-lock.json with upstream/master * stub window.top in tests * introduce getTopWindowSize() for test purpose * reformat code * add withSite() method to TtxRequestBuilder add withSite() method to TtxRequestBuilder * add isIframe() and _isViewabilityMeasurable() * handle NON_MEASURABLE viewability in nested iframes * consider page visibility, stub utils functions getWindowTop() and getWindowSelf() * contribute viewability as 0 for inactive tab * add prebidjs version to ttx request * send caller as an array * fix JSDoc in utils.js * send viewability as non measurable when unable to locate target HTMLElement, add warning message * introduce mapAdSlotPathToElementId() * introduce getAdSlotHTMLElement(), add logging * introduce mapAdSlotPathToElementId() * update logging in ad unit path to element id mapping * rephrase logging, fix tests * update adapter documentation * remove excessive logging * improve logging * revert change * fix return of _mapAdUnitPathToElementId() * improve logging of _mapAdUnitPathToElementId() * do not use Array.find() * return id once element is found * return id once element is found * let -> const * Removing killswitch behavior for GDPR * Updated comments to reflect current gdpr logic * URI encode consent string * Updated example site ID to help Prebid team e2e test our adapter * send page url in ortb * Removed redundant pageUrl default * Restored package-log.json that mirrors prebid's repo * Sending USP string during buildRequest * Adding USP consent data to user sync * add unit test for syncing without bidrequest * Changed to uspConsent to make the connatation consistent * Resetting adapter state in adapter after user sync rather than exposing it. * removed console log * Adding schain info * remove setting empty format ext * better tests invalid values * removing validation of schain * Fixed lint errors * First cut for bidfloors support * fixed where getFloors is read * fixed merge conflicts Co-authored-by: Gleb Glushtsov <gleb.glushtsov@33across.com> Co-authored-by: Gleb Glushtsov <glebglushtsov@users.noreply.github.com> Co-authored-by: Gleb Glushtsov <gleb.glushtsov@gmail.com> Co-authored-by: Aparna Hegde <ahegde@pool-10-1-150-29-nyc.internal.33across.com> Co-authored-by: Aparna Hegde <ahegde@admins-MacBook-Pro.local> Co-authored-by: Aparna Hegde <ahegde@pool-10-1-150-137-nyc.internal.33across.com> Co-authored-by: Aparna Hegde <ahegde@pool-10-1-150-96-nyc.internal.33across.com> Co-authored-by: Aparna Hegde <ahegde@AHEGDE-MAC.local> Co-authored-by: Aparna Hegde <ahegde@AHEGDE-MAC.fios-router.home>
* feat(module): multi size request * fix getUserSyncs added tests * update(module): package-lock.json from master * feat(client): add screen resolution as request param * feat(client): add `res` param to spec * fix(client): screen size inside test Co-authored-by: roman <shmoop207@gmail.com>
* Add initial partial implementation for Appier bidder adapter. * Use relative protocol for bidder API url. * Handle server response for Appier adapter and add related unit tests. * Support farm-specific prebid server and allow overriding the server with setConfig(). * Add doc for Appier bid adapter. * Fix const correctness. * Append requestId to the beacon image URL of Appier adapter to reduce the risks of being cached by proxy servers or browsers. * Send bidderRequest.refererInfo to Appier bidder server. * Remove the show beacon since now we generate it in the backend server. * Only generate a show beacon url if it's not provided by the backend. * Add version information for Appier adapter using semver (starts from 1.0.0). * Add a new adapter for Appier bidder. * Add a new adapter for Appier bidder. * add appier analyticsAdapter skeleton. * update initial working version. * refactor and remove debug messages. * fix config checking logic. * implement bidAdjustment and add timeout before send event. * unify cache operation into cacheManager to avoid direct key/value operation. * Update server name. * correct currency impl and message payload. remove unused debug messages. * update var naming. * rename creative vars. cleanup comments. * add test cases for AnalyticsAdapter. * update test specs file. * remove spec from main branch. * add unit tests for AnalyticsAdapter, #1 - Happy cases. * refactor tests. * update unit tests for AnalyticsAdapter. * add tests for bid-adjusted, bid-timeout events * fix bid adjustment test case. * add nobid case in analytics unit test. * add test case for delayed bids and prebidWon messages. * Use logInfo and logError utilility functions instead of console.log() to print debug messages. * handle timeout status message correctly. * correct isTimeout setting logic and test cases. * replace for...of by array.forEach for IE11 * apply auto formatter. * refactor: extract timeout logic to a helper function * tag analytic version with 0.1.0-beta for iCook release * Re-implement the appier analytics adapter with a simpler design and correctly handle timeouts. * Remove unused variables. * Rename methods to improve consistency. * Code cleanup: rename methods and avoid duplicated code. * Fix wrong bid response data caused by non-deterministic event ordering of prebid.js. * Send bid message immediately on auction end without delay. * add withCredentials in ajax call to get client cookie. * Fix broken unit test for appier analytic adapter. * add prediction id support. * update predictionId/configId format in tests. * Init refined appier analytics testing * hotfix: appier analytics support browserstack bug * feat: add aliases Co-authored-by: Hong Jen-Yee (PCMan) <pcman.hong@appier.com> Co-authored-by: Yuan-Hung Huang <yuanhung.huang@appier.com> Co-authored-by: kdchang <kd.chang@appier.com> Co-authored-by: chih-ping-weng <chihping.weng@appier.com>
* Add GMOSSP Adapter * fix test param
ikagotso
pushed a commit
that referenced
this pull request
Nov 14, 2023
* KargoBidAdapter: GPP Support * kargo adapter to forward schain object (#21) * wrap in if statement (#22) * KRKPD-572: Add spec for schain (#23) * wrap in if statement * update test for schain, file formatting * Adding site to Kargo adapter. * KRKPD-619 Updating Site object. * KRKPD-619 Adding null check for Site object. * Update modules/kargoBidAdapter.js Co-authored-by: Julian Gan <juliangan07@gmail.com> * Reducing the size of Site object. * remove white space that is causing linting error --------- Co-authored-by: Jeremy Sadwith <jeremy@kargo.com> Co-authored-by: Julian Gan <juliangan07@gmail.com>
ikagotso
pushed a commit
that referenced
this pull request
Nov 14, 2023
* KargoBidAdapter: GPP Support * kargo adapter to forward schain object (#21) * wrap in if statement (#22) * KRKPD-572: Add spec for schain (#23) * wrap in if statement * update test for schain, file formatting * Adding site to Kargo adapter. * KRKPD-619 Updating Site object. * KRKPD-619 Adding null check for Site object. * Update modules/kargoBidAdapter.js Co-authored-by: Julian Gan <juliangan07@gmail.com> * Reducing the size of Site object. * remove white space that is causing linting error * Kargo Bid Adapter: Updates to gpid retrieval --------- Co-authored-by: Julian Gan <juliangan07@gmail.com> Co-authored-by: Neil Flynn <nflynn@kargo.com>
ikagotso
pushed a commit
that referenced
this pull request
Nov 14, 2023
* KargoBidAdapter: GPP Support * kargo adapter to forward schain object (#21) * wrap in if statement (#22) * KRKPD-572: Add spec for schain (#23) * wrap in if statement * update test for schain, file formatting * Adding site to Kargo adapter. * KRKPD-619 Updating Site object. * KRKPD-619 Adding null check for Site object. * Update modules/kargoBidAdapter.js Co-authored-by: Julian Gan <juliangan07@gmail.com> * Reducing the size of Site object. * remove white space that is causing linting error * Kargo Bid Adapter: Updates to gpid retrieval * Support for sending ortb2.user.data --------- Co-authored-by: Julian Gan <juliangan07@gmail.com> Co-authored-by: Neil Flynn <nflynn@kargo.com>
ikagotso
pushed a commit
that referenced
this pull request
Mar 14, 2024
* KargoBidAdapter: GPP Support * kargo adapter to forward schain object (#21) * wrap in if statement (#22) * KRKPD-572: Add spec for schain (#23) * wrap in if statement * update test for schain, file formatting * Adding site to Kargo adapter. * KRKPD-619 Updating Site object. * KRKPD-619 Adding null check for Site object. * Update modules/kargoBidAdapter.js Co-authored-by: Julian Gan <juliangan07@gmail.com> * Reducing the size of Site object. * remove white space that is causing linting error * Kargo Bid Adapter: Updates to gpid retrieval * Support for sending ortb2.user.data * update bid Response to use actual creativeID * update spec * fix nomencalature based on Kargo's service * Prebid.js - Update bid Response to use actual creativeID (#25) * update bid Response to use actual creativeID * update spec * fix nomencalature based on Kargo's service * utilize floors mod * fixes tests * mediatype specific floors * simpler implementation leveraging Prebid's smart rule selection * revert nomenclature change * fix * removes comment --------- Co-authored-by: Jeremy Sadwith <jeremy@kargo.com> Co-authored-by: Julian Gan <juliangan07@gmail.com> Co-authored-by: Neil Flynn <nflynn@kargo.com> Co-authored-by: “Nick <“nick.llerandi”@kargo.com> Co-authored-by: Nick Llerandi <nick.llerandi@kargo.com>
ikagotso
pushed a commit
that referenced
this pull request
Mar 27, 2024
* create setupadBidAdapter * add setupadBidAdapter * update setupadBidAdapter * update metrics collection * update analytics collection * update getUserSyncs * add setupadAnalyticsAdapter.js * test setupadAnalyticsAdapter * remove test: 1 * add GVLID && bug fixes && test updates * remove setupadAnalyticsAdapter * add userID module handling * add GVLID && bug fixes && test updates * remove setupadAnalyticsAdapter * add userID module handling * clean up && seat bugfix * clean up logs * add userID module handling * update md && clean up * Send setupad only on bidRequested * Fix bidResponse and bidWon responses * Improve bidResponse and bidWon logic * Revert changes to specific files * Remove test parameter * Fix multiple bidResponse and bidTimeout calls to getPixelUrl * eslint errors fixes(brackets added) * Add extra checks for events * Fix BIDDER_CODE const * update reporting endpoint * update setupadBidAdapter_spec.js REPORT_ENDPOINT * update readme * Revert "Merge branch 'prebid:master' into setupad-adapter" This reverts commit 1c14dbe, reversing changes made to 7fe9ea5. * Revert "Revert "Merge branch 'prebid:master' into setupad-adapter"" This reverts commit a34e3e4. * # This is a combination of 20 commits. # This is the 1st commit message: add setupadBidAdapter # This is the commit message #2: update setupadBidAdapter # This is the commit message #3: update metrics collection # This is the commit message #4: update analytics collection # This is the commit message #5: update getUserSyncs # This is the commit message #6: add setupadAnalyticsAdapter.js # This is the commit message #7: test setupadAnalyticsAdapter # This is the commit message #8: remove test: 1 # This is the commit message #9: add GVLID && bug fixes && test updates # This is the commit message #10: remove setupadAnalyticsAdapter # This is the commit message #11: add userID module handling # This is the commit message #12: clean up && seat bugfix # This is the commit message #13: add userID module handling # This is the commit message #14: add GVLID && bug fixes && test updates # This is the commit message #15: remove setupadAnalyticsAdapter # This is the commit message #16: add userID module handling # This is the commit message #17: clean up logs # This is the commit message #18: update md && clean up # This is the commit message #19: Send setupad only on bidRequested # This is the commit message #20: Fix bidResponse and bidWon responses * # This is a combination of 22 commits.tree 8abae7e6dffc9a21ad11770713ba485fc610028a parent cecfce3 author pavel <pavel@setupad.com> 1706627437 +0200 committer pavel <pavel@setupad.com> 1706627437 +0200 gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5EW0ACgkQFABtd4pC s/CK3w//WWJSFUlycnnNKTV2XfdcBjooOeZZvjpXVthwr09CCC4uO//kw4bPluhn f5fcVFdXzrY1AZ6ch8Wo3msX/Pkso014jIGd5aIWcHpNYFtffACwH/40Y8AcJNZd bsOZxVK0awPTz/RihC5eY+0J3cP+iFWP/FlYJoHEQIBXq/Eg6mWoAhxwpL/JvxbY QbLFWsRn2ckQ6ftOZgm3/jh8VLaG1zWbWImlWEs5Zel+CorJBTniTj58VbApelYD TFMgbSR2I4NGVaqNIrHePnSMsDATxalQ2nZPwY6raKCHWIbvoUPIn/OpDMMbKgC7 nCwounNmObxFVoj3xusAZppzHpKPasY8xKWb2Kr7zfhZArsOMC6B7fYqQNK0cWG3 8RR/10oheJD9M2kRlfLiqnRv7ExY08SQ/ZMo9LA8BeRUGBXhh6++8FKhKIHvX1gL k1R5W6c+NNWP+PDFsmrFpMn+LpYdl84I7yfYK5dHuw80od7f1wuAVYpswi6Cziy9 /KY6/rfENvUrGTmWSh5GdDBel89ACCfFkasIKB92xhzKTfjzF/DXkc8XQZOMbt1j CsILgWMNfLPMo4Dlgdx/tYCSLLBNEtZ1/hhUcFQ3+0TzLf0GtMkvMnlBnDinqe1n 1P30fQ2I5W5NJKDPrCOnRymI6QOAPFXtMF11R81mbB9H8asft/E= =oJtZ -----END PGP SIGNATURE----- bugfixes # This is the commit message #22: Remove test parameter * # This is a combination of 26 commits. parent cecfce3 author pavel <pavel@setupad.com> 1706627437 +0200 committer pavel <pavel@setupad.com> 1706627437 +0200 gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5EW0ACgkQFABtd4pC s/CK3w//WWJSFUlycnnNKTV2XfdcBjooOeZZvjpXVthwr09CCC4uO//kw4bPluhn f5fcVFdXzrY1AZ6ch8Wo3msX/Pkso014jIGd5aIWcHpNYFtffACwH/40Y8AcJNZd bsOZxVK0awPTz/RihC5eY+0J3cP+iFWP/FlYJoHEQIBXq/Eg6mWoAhxwpL/JvxbY QbLFWsRn2ckQ6ftOZgm3/jh8VLaG1zWbWImlWEs5Zel+CorJBTniTj58VbApelYD TFMgbSR2I4NGVaqNIrHePnSMsDATxalQ2nZPwY6raKCHWIbvoUPIn/OpDMMbKgC7 nCwounNmObxFVoj3xusAZppzHpKPasY8xKWb2Kr7zfhZArsOMC6B7fYqQNK0cWG3 8RR/10oheJD9M2kRlfLiqnRv7ExY08SQ/ZMo9LA8BeRUGBXhh6++8FKhKIHvX1gL k1R5W6c+NNWP+PDFsmrFpMn+LpYdl84I7yfYK5dHuw80od7f1wuAVYpswi6Cziy9 /KY6/rfENvUrGTmWSh5GdDBel89ACCfFkasIKB92xhzKTfjzF/DXkc8XQZOMbt1j CsILgWMNfLPMo4Dlgdx/tYCSLLBNEtZ1/hhUcFQ3+0TzLf0GtMkvMnlBnDinqe1n 1P30fQ2I5W5NJKDPrCOnRymI6QOAPFXtMF11R81mbB9H8asft/E= =oJtZ -----END PGP SIGNATURE----- bugfixes # This is the commit message #22: Remove test parameter # This is the commit message #23: Fix multiple bidResponse and bidTimeout calls to getPixelUrl # This is the commit message #25: eslint errors fixes(brackets added) # This is the commit message #26: Add extra checks for events * parent 75178b9 author pavel <pavel@setupad.com> 1706627694 +0200 committer pavel <pavel@setupad.com> 1706627694 +0200 gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5Em4ACgkQFABtd4pC s/BBUQ/+NXyHoxPM185YJLG9M1ySC/5vTT9W5mfwQ93cVDLCeuGnpsnmi4S21NuQ b7gSeokFjwztvVOUmh/xqMp4lTsvL53TUd00b1k4KGVSqgcF00Foit5g8fOGLYsI DAoqphYV6MWjpAun+II+ELY8QUkHR1cjTc7PEGtmf+8RnptGVdyJ6C9Ab8u9TQTY Apj5Srhfo3Tl8S+WScOxwwB/uqEJR4fhIrJyzFzdLDEb2olSPyrQUs87vQXlhEnK buPEg2F5JsRH6sw11Xp3TFNSZGxNnBSlTh9dixou5md4yRCv5a2TMef667N0BVDp lGgc7mCrRKXyqzphmmeHudiscEGFjtUPObXoHutSVw22wdARFCTpNFKBLLFn4v8o Zv1OvFdNprvHsoeW0HVlZdU7OKnDTRrko6DHk2AahxojjvAFEWuDsGYZNjhdQwRR lK1zm+SFQnKI0Eojd+f84fvKod9geGs640jyH/x5R4eYm4yjZb8SkRtd3cca88wS OuGq9LIkbU428b46l7VnDwudldTXPUU8eKfUtFRjdGtIWH9I3tK6TsRoCfTcXkv0 smxYiiU1XHjAkkPFWQWEeFdfZ071snFKVWouU0AoKiq+PdRoS8+3AJqIQUjlA2sH AybnSkv9KxY/Rs1bnvMubsQm1GF66qVrbxBU6FILBv1JZYwj4yA= =Gbog -----END PGP SIGNATURE----- bugfixes update setupadBidAdapter_spec.js REPORT_ENDPOINT update readme Revert "Merge branch 'prebid:master' into setupad-adapter" This reverts commit 1c14dbe, reversing changes made to 7fe9ea5. Revert "Revert "Merge branch 'prebid:master' into setupad-adapter"" This reverts commit a34e3e4. * change double quote to single quote --------- Co-authored-by: pavel <pavel@setupad.com> Co-authored-by: Elgars Grodnis <elgars@setupad.com> * bugfix setupadBidAdapter remove getAdEl, spelling correction * add onBidWon event onBidWon event handling moved from custom to native onBidWon method * minor bugfixes && remove funk getSiteObj && getDeviceObj --------- Co-authored-by: pavel <pavel@setupad.com> Co-authored-by: Elgars Grodnis <elgars@setupad.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information